NFC: pn533: Fix use after free
cmd was freed in pn533_dep_link_up regardless of pn533_send_cmd_frame_async return code. Cmd is passed as argument to pn533_in_dep_link_up_complete callback and should be freed there. Signed-off-by: Szymon Janc <szymon.janc@tieto.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Родитель
60ad07ab6b
Коммит
770f750bc2
|
@ -1820,12 +1820,8 @@ static int pn533_dep_link_up(struct nfc_dev *nfc_dev, struct nfc_target *target,
|
|||
rc = pn533_send_cmd_frame_async(dev, dev->out_frame, dev->in_frame,
|
||||
dev->in_maxlen, pn533_in_dep_link_up_complete,
|
||||
cmd, GFP_KERNEL);
|
||||
if (rc)
|
||||
goto out;
|
||||
|
||||
|
||||
out:
|
||||
kfree(cmd);
|
||||
if (rc < 0)
|
||||
kfree(cmd);
|
||||
|
||||
return rc;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче