drivers/pcmcia: remove unnecessary kzalloc
The result of calling kzalloc is never used or freed. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
This commit is contained in:
Родитель
b285fab418
Коммит
78a14e273d
|
@ -127,10 +127,6 @@ int sa1111_pcmcia_add(struct sa1111_dev *dev, struct pcmcia_low_level *ops,
|
||||||
ops->socket_state = sa1111_pcmcia_socket_state;
|
ops->socket_state = sa1111_pcmcia_socket_state;
|
||||||
ops->socket_suspend = sa1111_pcmcia_socket_suspend;
|
ops->socket_suspend = sa1111_pcmcia_socket_suspend;
|
||||||
|
|
||||||
s = kzalloc(sizeof(*s) * ops->nr, GFP_KERNEL);
|
|
||||||
if (!s)
|
|
||||||
return -ENODEV;
|
|
||||||
|
|
||||||
for (i = 0; i < ops->nr; i++) {
|
for (i = 0; i < ops->nr; i++) {
|
||||||
s = kzalloc(sizeof(*s), GFP_KERNEL);
|
s = kzalloc(sizeof(*s), GFP_KERNEL);
|
||||||
if (!s)
|
if (!s)
|
||||||
|
|
Загрузка…
Ссылка в новой задаче