staging: comedi: pcmuio: use comedi_buf_write_samples()
The dev->read_subdev used in this driver for async commands returns 32-bit samples and should have the SDF_LSAMPL subdev_flag set. It also returns the full scan with each sample so it should have the SDF_PACKED subdev_flag set. Add the missing subdev_flags and use comedi_buf_write_samples() to add the sample to the async buffer. The COMEDI_CB_BLOCK and COMEDI_CB_EOS events will be automatically handled by the core. Remove the unnecessary events in the driver. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
ff5eb046cf
Коммит
7dd1b528c1
|
@ -336,10 +336,7 @@ static void pcmuio_handle_intr_subdev(struct comedi_device *dev,
|
|||
val |= (1 << i);
|
||||
}
|
||||
|
||||
/* Write the scan to the buffer. */
|
||||
if (comedi_buf_put(s, val) &&
|
||||
comedi_buf_put(s, val >> 16))
|
||||
s->async->events |= (COMEDI_CB_BLOCK | COMEDI_CB_EOS);
|
||||
comedi_buf_write_samples(s, &val, 1);
|
||||
|
||||
/* Check for end of acquisition. */
|
||||
if (cmd->stop_src == TRIG_COUNT) {
|
||||
|
@ -604,7 +601,8 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
|
|||
if ((i == 0 && dev->irq) || (i == 2 && devpriv->irq2)) {
|
||||
/* setup the interrupt subdevice */
|
||||
dev->read_subdev = s;
|
||||
s->subdev_flags |= SDF_CMD_READ;
|
||||
s->subdev_flags |= SDF_CMD_READ | SDF_LSAMPL |
|
||||
SDF_PACKED;
|
||||
s->len_chanlist = s->n_chan;
|
||||
s->cancel = pcmuio_cancel;
|
||||
s->do_cmd = pcmuio_cmd;
|
||||
|
|
Загрузка…
Ссылка в новой задаче