[SCSI] mpt2sas: Fix mismatch in mpt2sas_base_hard_reset_handler() mutex lock-unlock
If ioc->pci_error_recovery is set, goto out in mpt2sas_base_hard_reset_handler() leads to unlock unheld ioc->reset_in_progress_mutex. The patch fixes the issue by jumping afer mutex_unlock() call. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
Родитель
3ec1e88b33
Коммит
7fbd764881
|
@ -4548,7 +4548,7 @@ mpt2sas_base_hard_reset_handler(struct MPT2SAS_ADAPTER *ioc, int sleep_flag,
|
|||
printk(MPT2SAS_ERR_FMT "%s: pci error recovery reset\n",
|
||||
ioc->name, __func__);
|
||||
r = 0;
|
||||
goto out;
|
||||
goto out_unlocked;
|
||||
}
|
||||
|
||||
if (mpt2sas_fwfault_debug)
|
||||
|
@ -4604,6 +4604,7 @@ mpt2sas_base_hard_reset_handler(struct MPT2SAS_ADAPTER *ioc, int sleep_flag,
|
|||
spin_unlock_irqrestore(&ioc->ioc_reset_in_progress_lock, flags);
|
||||
mutex_unlock(&ioc->reset_in_progress_mutex);
|
||||
|
||||
out_unlocked:
|
||||
dtmprintk(ioc, printk(MPT2SAS_INFO_FMT "%s: exit\n", ioc->name,
|
||||
__func__));
|
||||
return r;
|
||||
|
|
Загрузка…
Ссылка в новой задаче