ARM: perf: make name of arm_pmu_type consistent
Commit f12482c9
("ARM: 6974/1: pmu: refactor reservation") changed
{release,reserve}_pmu to take an enum arm_pmu_type as a parameter, but
inconsistently named the parameter `type' or `device'. It would be nice
if these were consistent.
This patch makes use of enum arm_pmu_type consistent, always using
`type'. Related printks are updated, explicitly mentioning `type' also.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
This commit is contained in:
Родитель
49bef8331a
Коммит
7fdd3c4962
|
@ -41,7 +41,7 @@ struct arm_pmu_platdata {
|
||||||
* encoded error on failure.
|
* encoded error on failure.
|
||||||
*/
|
*/
|
||||||
extern struct platform_device *
|
extern struct platform_device *
|
||||||
reserve_pmu(enum arm_pmu_type device);
|
reserve_pmu(enum arm_pmu_type type);
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* release_pmu() - Relinquish control of the performance counters
|
* release_pmu() - Relinquish control of the performance counters
|
||||||
|
@ -62,26 +62,26 @@ release_pmu(enum arm_pmu_type type);
|
||||||
* the actual hardware initialisation.
|
* the actual hardware initialisation.
|
||||||
*/
|
*/
|
||||||
extern int
|
extern int
|
||||||
init_pmu(enum arm_pmu_type device);
|
init_pmu(enum arm_pmu_type type);
|
||||||
|
|
||||||
#else /* CONFIG_CPU_HAS_PMU */
|
#else /* CONFIG_CPU_HAS_PMU */
|
||||||
|
|
||||||
#include <linux/err.h>
|
#include <linux/err.h>
|
||||||
|
|
||||||
static inline struct platform_device *
|
static inline struct platform_device *
|
||||||
reserve_pmu(enum arm_pmu_type device)
|
reserve_pmu(enum arm_pmu_type type)
|
||||||
{
|
{
|
||||||
return ERR_PTR(-ENODEV);
|
return ERR_PTR(-ENODEV);
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline int
|
static inline int
|
||||||
release_pmu(enum arm_pmu_type device)
|
release_pmu(enum arm_pmu_type type)
|
||||||
{
|
{
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline int
|
static inline int
|
||||||
init_pmu(enum arm_pmu_type device)
|
init_pmu(enum arm_pmu_type type)
|
||||||
{
|
{
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
}
|
}
|
||||||
|
|
|
@ -31,7 +31,7 @@ static int __devinit pmu_register(struct platform_device *pdev,
|
||||||
{
|
{
|
||||||
if (type < 0 || type >= ARM_NUM_PMU_DEVICES) {
|
if (type < 0 || type >= ARM_NUM_PMU_DEVICES) {
|
||||||
pr_warning("received registration request for unknown "
|
pr_warning("received registration request for unknown "
|
||||||
"device %d\n", type);
|
"PMU device type %d\n", type);
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -112,17 +112,17 @@ static int __init register_pmu_driver(void)
|
||||||
device_initcall(register_pmu_driver);
|
device_initcall(register_pmu_driver);
|
||||||
|
|
||||||
struct platform_device *
|
struct platform_device *
|
||||||
reserve_pmu(enum arm_pmu_type device)
|
reserve_pmu(enum arm_pmu_type type)
|
||||||
{
|
{
|
||||||
struct platform_device *pdev;
|
struct platform_device *pdev;
|
||||||
|
|
||||||
if (test_and_set_bit_lock(device, &pmu_lock)) {
|
if (test_and_set_bit_lock(type, &pmu_lock)) {
|
||||||
pdev = ERR_PTR(-EBUSY);
|
pdev = ERR_PTR(-EBUSY);
|
||||||
} else if (pmu_devices[device] == NULL) {
|
} else if (pmu_devices[type] == NULL) {
|
||||||
clear_bit_unlock(device, &pmu_lock);
|
clear_bit_unlock(type, &pmu_lock);
|
||||||
pdev = ERR_PTR(-ENODEV);
|
pdev = ERR_PTR(-ENODEV);
|
||||||
} else {
|
} else {
|
||||||
pdev = pmu_devices[device];
|
pdev = pmu_devices[type];
|
||||||
}
|
}
|
||||||
|
|
||||||
return pdev;
|
return pdev;
|
||||||
|
@ -130,11 +130,11 @@ reserve_pmu(enum arm_pmu_type device)
|
||||||
EXPORT_SYMBOL_GPL(reserve_pmu);
|
EXPORT_SYMBOL_GPL(reserve_pmu);
|
||||||
|
|
||||||
int
|
int
|
||||||
release_pmu(enum arm_pmu_type device)
|
release_pmu(enum arm_pmu_type type)
|
||||||
{
|
{
|
||||||
if (WARN_ON(!pmu_devices[device]))
|
if (WARN_ON(!pmu_devices[type]))
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
clear_bit_unlock(device, &pmu_lock);
|
clear_bit_unlock(type, &pmu_lock);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL_GPL(release_pmu);
|
EXPORT_SYMBOL_GPL(release_pmu);
|
||||||
|
@ -182,17 +182,17 @@ init_cpu_pmu(void)
|
||||||
}
|
}
|
||||||
|
|
||||||
int
|
int
|
||||||
init_pmu(enum arm_pmu_type device)
|
init_pmu(enum arm_pmu_type type)
|
||||||
{
|
{
|
||||||
int err = 0;
|
int err = 0;
|
||||||
|
|
||||||
switch (device) {
|
switch (type) {
|
||||||
case ARM_PMU_DEVICE_CPU:
|
case ARM_PMU_DEVICE_CPU:
|
||||||
err = init_cpu_pmu();
|
err = init_cpu_pmu();
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
pr_warning("attempt to initialise unknown device %d\n",
|
pr_warning("attempt to initialise PMU of unknown "
|
||||||
device);
|
"type %d\n", type);
|
||||||
err = -EINVAL;
|
err = -EINVAL;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче