scsi: scsi_dh_alua: Fix signedness bug in alua_rtpg()
The "retval" variable needs to be signed for the error handling to work.
Link: https://lore.kernel.org/r/YLjMEAFNxOas1mIp@mwanda
Fixes: 7e26e3ea02
("scsi: scsi_dh_alua: Check for negative result value")
Reviewed-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Родитель
8b1afb7ab0
Коммит
80927822e8
|
@ -518,7 +518,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
|
||||||
int len, k, off, bufflen = ALUA_RTPG_SIZE;
|
int len, k, off, bufflen = ALUA_RTPG_SIZE;
|
||||||
int group_id_old, state_old, pref_old, valid_states_old;
|
int group_id_old, state_old, pref_old, valid_states_old;
|
||||||
unsigned char *desc, *buff;
|
unsigned char *desc, *buff;
|
||||||
unsigned err, retval;
|
unsigned err;
|
||||||
|
int retval;
|
||||||
unsigned int tpg_desc_tbl_off;
|
unsigned int tpg_desc_tbl_off;
|
||||||
unsigned char orig_transition_tmo;
|
unsigned char orig_transition_tmo;
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче