hwmon: (acpi_power_meter) Don't crash the kernel unnecessarily
acpi_power_meter crashes the kernel if it detects an unexpected event or an internal implementation error. While the detected conditions suggest that there is a bug in the code, the condition is not fatal. Replace BUG() with WARN(). Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Родитель
c52ae3d279
Коммит
83c97fe13e
|
@ -381,8 +381,10 @@ static ssize_t show_str(struct device *dev,
|
||||||
val = resource->oem_info;
|
val = resource->oem_info;
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
BUG();
|
WARN(1, "Implementation error: unexpected attribute index %d\n",
|
||||||
|
attr->index);
|
||||||
val = "";
|
val = "";
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
return sprintf(buf, "%s\n", val);
|
return sprintf(buf, "%s\n", val);
|
||||||
|
@ -436,7 +438,9 @@ static ssize_t show_val(struct device *dev,
|
||||||
val = resource->trip[attr->index - 7] * 1000;
|
val = resource->trip[attr->index - 7] * 1000;
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
BUG();
|
WARN(1, "Implementation error: unexpected attribute index %d\n",
|
||||||
|
attr->index);
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
return sprintf(buf, "%llu\n", val);
|
return sprintf(buf, "%llu\n", val);
|
||||||
|
@ -855,7 +859,8 @@ static void acpi_power_meter_notify(struct acpi_device *device, u32 event)
|
||||||
dev_info(&device->dev, "Capping in progress.\n");
|
dev_info(&device->dev, "Capping in progress.\n");
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
BUG();
|
WARN(1, "Unexpected event %d\n", event);
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
mutex_unlock(&resource->lock);
|
mutex_unlock(&resource->lock);
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче