f2fs: fix reference leaks in f2fs_acl_create
Our f2fs_acl_create is copied and modified from posix_acl_create to avoid
deadlock bug when inline_dentry feature is enabled.
Now, we got reference leaks in posix_acl_create, and this has been fixed in
commit fed0b588be
("posix_acl: fix reference leaks in posix_acl_create")
by Omar Sandoval.
https://lkml.org/lkml/2015/2/9/5
Let's fix this issue in f2fs_acl_create too.
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Reviewed-by: Changman Lee <cm224.lee@ssamsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
Родитель
bda190760b
Коммит
83dfe53c18
|
@ -351,13 +351,11 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode,
|
||||||
|
|
||||||
*acl = f2fs_acl_clone(p, GFP_NOFS);
|
*acl = f2fs_acl_clone(p, GFP_NOFS);
|
||||||
if (!*acl)
|
if (!*acl)
|
||||||
return -ENOMEM;
|
goto no_mem;
|
||||||
|
|
||||||
ret = f2fs_acl_create_masq(*acl, mode);
|
ret = f2fs_acl_create_masq(*acl, mode);
|
||||||
if (ret < 0) {
|
if (ret < 0)
|
||||||
posix_acl_release(*acl);
|
goto no_mem_clone;
|
||||||
return -ENOMEM;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (ret == 0) {
|
if (ret == 0) {
|
||||||
posix_acl_release(*acl);
|
posix_acl_release(*acl);
|
||||||
|
@ -378,6 +376,12 @@ no_acl:
|
||||||
*default_acl = NULL;
|
*default_acl = NULL;
|
||||||
*acl = NULL;
|
*acl = NULL;
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
no_mem_clone:
|
||||||
|
posix_acl_release(*acl);
|
||||||
|
no_mem:
|
||||||
|
posix_acl_release(p);
|
||||||
|
return -ENOMEM;
|
||||||
}
|
}
|
||||||
|
|
||||||
int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage,
|
int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage,
|
||||||
|
|
Загрузка…
Ссылка в новой задаче