debugfs: move to new strtobool
No functional changes requires that we eat errors from strtobool. If people want to not do this, then it should be fixed at a later date. V2: Simplification suggested by Rusty Russell removes the need for additional variable ret. Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Родитель
ad58671cf3
Коммит
8705b48e71
|
@ -429,24 +429,15 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf,
|
||||||
{
|
{
|
||||||
char buf[32];
|
char buf[32];
|
||||||
int buf_size;
|
int buf_size;
|
||||||
|
bool bv;
|
||||||
u32 *val = file->private_data;
|
u32 *val = file->private_data;
|
||||||
|
|
||||||
buf_size = min(count, (sizeof(buf)-1));
|
buf_size = min(count, (sizeof(buf)-1));
|
||||||
if (copy_from_user(buf, user_buf, buf_size))
|
if (copy_from_user(buf, user_buf, buf_size))
|
||||||
return -EFAULT;
|
return -EFAULT;
|
||||||
|
|
||||||
switch (buf[0]) {
|
if (strtobool(buf, &bv) == 0)
|
||||||
case 'y':
|
*val = bv;
|
||||||
case 'Y':
|
|
||||||
case '1':
|
|
||||||
*val = 1;
|
|
||||||
break;
|
|
||||||
case 'n':
|
|
||||||
case 'N':
|
|
||||||
case '0':
|
|
||||||
*val = 0;
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
|
|
||||||
return count;
|
return count;
|
||||||
}
|
}
|
||||||
|
|
Загрузка…
Ссылка в новой задаче