linux/build_bug.h: change type to int
Having BUILD_BUG_ON_ZERO produce a value of type size_t leads to awkward casts in cases where the result needs to be signed, or of smaller type than size_t. To avoid this, cast the value to int instead and rely on implicit type conversions when a larger or unsigned type is needed. Link: http://lkml.kernel.org/r/20190811184938.1796-3-rikard.falkeborn@gmail.com Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Joe Perches <joe@perches.com> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
a512ae54ce
Коммит
8788994376
|
@ -9,11 +9,11 @@
|
||||||
#else /* __CHECKER__ */
|
#else /* __CHECKER__ */
|
||||||
/*
|
/*
|
||||||
* Force a compilation error if condition is true, but also produce a
|
* Force a compilation error if condition is true, but also produce a
|
||||||
* result (of value 0 and type size_t), so the expression can be used
|
* result (of value 0 and type int), so the expression can be used
|
||||||
* e.g. in a structure initializer (or where-ever else comma expressions
|
* e.g. in a structure initializer (or where-ever else comma expressions
|
||||||
* aren't permitted).
|
* aren't permitted).
|
||||||
*/
|
*/
|
||||||
#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
|
#define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
|
||||||
#endif /* __CHECKER__ */
|
#endif /* __CHECKER__ */
|
||||||
|
|
||||||
/* Force a compilation error if a constant expression is not a power of 2 */
|
/* Force a compilation error if a constant expression is not a power of 2 */
|
||||||
|
|
Загрузка…
Ссылка в новой задаче