ipv6: move dereference after check in fl_free()
There is a dereference before checking for NULL bug here. Generally free() functions should accept NULL pointers. For example, fl_create() can pass a NULL pointer to fl_free() on the error path. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
This commit is contained in:
Родитель
0625c883bc
Коммит
898132ae76
|
@ -91,12 +91,9 @@ static struct ip6_flowlabel *fl_lookup(struct net *net, __be32 label)
|
|||
|
||||
static void fl_free(struct ip6_flowlabel *fl)
|
||||
{
|
||||
switch (fl->share) {
|
||||
case IPV6_FL_S_PROCESS:
|
||||
put_pid(fl->owner.pid);
|
||||
break;
|
||||
}
|
||||
if (fl) {
|
||||
if (fl->share == IPV6_FL_S_PROCESS)
|
||||
put_pid(fl->owner.pid);
|
||||
release_net(fl->fl_net);
|
||||
kfree(fl->opt);
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче