perf annotate: Reuse path from the result of addr2line
In the symbol__get_source_line(), path and src_line->path will have same value, but they were allocated separately, and leaks one. Just share path to src_line->path. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Reviewed-by: Jiri Olsa <jolsa@redhat.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1378876173-13363-3-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Родитель
963ba5fd5d
Коммит
89da393c17
|
@ -1143,11 +1143,7 @@ static int symbol__get_source_line(struct symbol *sym, struct map *map,
|
|||
if (getline(&path, &line_len, fp) < 0 || !line_len)
|
||||
goto next_close;
|
||||
|
||||
src_line->path = malloc(sizeof(char) * line_len + 1);
|
||||
if (!src_line->path)
|
||||
goto next_close;
|
||||
|
||||
strcpy(src_line->path, path);
|
||||
src_line->path = path;
|
||||
insert_source_line(&tmp_root, src_line);
|
||||
|
||||
next_close:
|
||||
|
|
Загрузка…
Ссылка в новой задаче