media: uvcvideo: fix division by zero at stream start
Add the missing bulk-endpoint max-packet sanity check to uvc_video_start_transfer() to avoid division by zero in uvc_alloc_urb_buffers() in case a malicious device has broken descriptors (or when doing descriptor fuzz testing). Note that USB core will reject URBs submitted for endpoints with zero wMaxPacketSize but that drivers doing packet-size calculations still need to handle this (cf. commit2548288b4f
("USB: Fix: Don't skip endpoint descriptors with maxpacket=0")). Fixes:c0efd23292
("V4L/DVB (8145a): USB Video Class driver") Cc: stable@vger.kernel.org # 2.6.26 Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Родитель
4b06506055
Коммит
8aa637bf6d
|
@ -1963,6 +1963,10 @@ static int uvc_video_start_transfer(struct uvc_streaming *stream,
|
|||
if (ep == NULL)
|
||||
return -EIO;
|
||||
|
||||
/* Reject broken descriptors. */
|
||||
if (usb_endpoint_maxp(&ep->desc) == 0)
|
||||
return -EIO;
|
||||
|
||||
ret = uvc_init_video_bulk(stream, ep, gfp_flags);
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче