drm: WARN when trying to add enum value > 63 to a bitmask property
Enum values >63 with a bitmask property is a programmer error. WARN when someone is attempting this. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180306164849.2862-3-ville.syrjala@linux.intel.com Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Родитель
1371f2604d
Коммит
8c6c2fe2f1
|
@ -386,8 +386,8 @@ int drm_property_add_enum(struct drm_property *property, int index,
|
|||
* Bitmask enum properties have the additional constraint of values
|
||||
* from 0 to 63
|
||||
*/
|
||||
if (drm_property_type_is(property, DRM_MODE_PROP_BITMASK) &&
|
||||
(value > 63))
|
||||
if (WARN_ON(drm_property_type_is(property, DRM_MODE_PROP_BITMASK) &&
|
||||
value > 63))
|
||||
return -EINVAL;
|
||||
|
||||
list_for_each_entry(prop_enum, &property->enum_list, head) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче