phy: marvell: phy-armada38x-comphy: Add of_node_put() before return
Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
This commit is contained in:
Родитель
4e99276a6f
Коммит
8d160f6b49
|
@ -200,8 +200,10 @@ static int a38x_comphy_probe(struct platform_device *pdev)
|
|||
}
|
||||
|
||||
phy = devm_phy_create(&pdev->dev, child, &a38x_comphy_ops);
|
||||
if (IS_ERR(phy))
|
||||
if (IS_ERR(phy)) {
|
||||
of_node_put(child);
|
||||
return PTR_ERR(phy);
|
||||
}
|
||||
|
||||
priv->lane[val].base = base + 0x28 * val;
|
||||
priv->lane[val].priv = priv;
|
||||
|
|
Загрузка…
Ссылка в новой задаче