usb: isp1760: check maxpacketsize before using it
When checking if we need one more packet on a bulk pipe we may, even though not probable at all, get there with a zero maxpacketsize. In that case for sure no packet, no even a one more, will be allocated. This will clean the clang-analyzer warning: drivers/usb/isp1760/isp1760-hcd.c:1856:38: warning: Division by zero [clang-analyzer-core.DivideZero] && !(urb->transfer_buffer_length % Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org> Link: https://lore.kernel.org/r/20210819180929.1327349-3-rui.silva@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
8472896f39
Коммит
8e58b7710d
|
@ -1854,7 +1854,7 @@ static void packetize_urb(struct usb_hcd *hcd,
|
|||
packet_type = OUT_PID;
|
||||
else
|
||||
packet_type = IN_PID;
|
||||
} else if (usb_pipebulk(urb->pipe)
|
||||
} else if (usb_pipebulk(urb->pipe) && maxpacketsize
|
||||
&& (urb->transfer_flags & URB_ZERO_PACKET)
|
||||
&& !(urb->transfer_buffer_length %
|
||||
maxpacketsize)) {
|
||||
|
|
Загрузка…
Ссылка в новой задаче