ksmbd: validate request buffer size in smb2_allocate_rsp_buf()

[ Upstream commit 17cf0c2794bdb6f39671265aa18aea5c22ee8c4a ]

The response buffer should be allocated in smb2_allocate_rsp_buf
before validating request. But the fields in payload as well as smb2 header
is used in smb2_allocate_rsp_buf(). This patch add simple buffer size
validation to avoid potencial out-of-bounds in request buffer.

Cc: stable@vger.kernel.org
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Namjae Jeon 2024-04-12 09:45:00 +09:00 коммит произвёл Greg Kroah-Hartman
Родитель da21401372
Коммит 8f3d0bf1d0
1 изменённых файлов: 4 добавлений и 0 удалений

Просмотреть файл

@ -536,6 +536,10 @@ int smb2_allocate_rsp_buf(struct ksmbd_work *work)
if (cmd == SMB2_QUERY_INFO_HE) { if (cmd == SMB2_QUERY_INFO_HE) {
struct smb2_query_info_req *req; struct smb2_query_info_req *req;
if (get_rfc1002_len(work->request_buf) <
offsetof(struct smb2_query_info_req, OutputBufferLength))
return -EINVAL;
req = smb2_get_msg(work->request_buf); req = smb2_get_msg(work->request_buf);
if ((req->InfoType == SMB2_O_INFO_FILE && if ((req->InfoType == SMB2_O_INFO_FILE &&
(req->FileInfoClass == FILE_FULL_EA_INFORMATION || (req->FileInfoClass == FILE_FULL_EA_INFORMATION ||