[media] usbvision: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Родитель
3724dde9c8
Коммит
8fe392b8fd
|
@ -189,8 +189,7 @@ int usbvision_i2c_register(struct usb_usbvision *usbvision)
|
|||
if (usbvision->registered_i2c)
|
||||
return 0;
|
||||
|
||||
memcpy(&usbvision->i2c_adap, &i2c_adap_template,
|
||||
sizeof(struct i2c_adapter));
|
||||
usbvision->i2c_adap = i2c_adap_template;
|
||||
|
||||
sprintf(usbvision->i2c_adap.name, "%s-%d-%s", i2c_adap_template.name,
|
||||
usbvision->dev->bus->busnum, usbvision->dev->devpath);
|
||||
|
|
Загрузка…
Ссылка в новой задаче