kernel/params.c: fix the maximum length in param_get_string
The length parameter of strlcpy() is supposed to reflect the size of the target buffer, not of the source string. Harmless in this case as the buffer is PAGE_SIZE long and the source string is always much shorter than this, but conceptually wrong, so let's fix it. Link: http://lkml.kernel.org/r/20170928162515.24846b4f@endymion Signed-off-by: Jean Delvare <jdelvare@suse.de> Acked-by: Ingo Molnar <mingo@kernel.org> Cc: Baoquan He <bhe@redhat.com> Cc: Michal Hocko <mhocko@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
d09b0137d2
Коммит
90ceb2a3ad
|
@ -507,7 +507,7 @@ EXPORT_SYMBOL(param_set_copystring);
|
|||
int param_get_string(char *buffer, const struct kernel_param *kp)
|
||||
{
|
||||
const struct kparam_string *kps = kp->str;
|
||||
return strlcpy(buffer, kps->string, kps->maxlen);
|
||||
return strlcpy(buffer, kps->string, PAGE_SIZE);
|
||||
}
|
||||
EXPORT_SYMBOL(param_get_string);
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче