ext2: Use kmemdup rather than duplicating its implementation
kmemdup is introduced to duplicate a region of memory in a neat way. Rather than kmalloc/kzalloc + memset, which the programmer needs to write the size twice (sometimes lead to mistakes), kmemdup improves readability, leads to smaller code and also reduce the chances of mistakes. Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset. Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> Link: https://lore.kernel.org/r/20190703131727.25735-1-huangfq.daxian@gmail.com Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Родитель
555b2c3da1
Коммит
90f15ac9fa
|
@ -532,11 +532,10 @@ bad_block:
|
|||
|
||||
unlock_buffer(bh);
|
||||
ea_bdebug(bh, "cloning");
|
||||
header = kmalloc(bh->b_size, GFP_KERNEL);
|
||||
header = kmemdup(HDR(bh), bh->b_size, GFP_KERNEL);
|
||||
error = -ENOMEM;
|
||||
if (header == NULL)
|
||||
goto cleanup;
|
||||
memcpy(header, HDR(bh), bh->b_size);
|
||||
header->h_refcount = cpu_to_le32(1);
|
||||
|
||||
offset = (char *)here - bh->b_data;
|
||||
|
|
Загрузка…
Ссылка в новой задаче