libceph: don't try checking queue_work() return value
queue_work() doesn't "fail to queue", it returns false if work was already on a queue, which can't happen here since we allocate event_work right before we queue it. So don't bother at all. Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com> Reviewed-by: Alex Elder <elder@linaro.org>
This commit is contained in:
Родитель
03974e8177
Коммит
91883cd27c
|
@ -2358,26 +2358,21 @@ static void handle_watch_notify(struct ceph_osd_client *osdc,
|
|||
if (event) {
|
||||
event_work = kmalloc(sizeof(*event_work), GFP_NOIO);
|
||||
if (!event_work) {
|
||||
dout("ERROR: could not allocate event_work\n");
|
||||
goto done_err;
|
||||
pr_err("couldn't allocate event_work\n");
|
||||
ceph_osdc_put_event(event);
|
||||
return;
|
||||
}
|
||||
INIT_WORK(&event_work->work, do_event_work);
|
||||
event_work->event = event;
|
||||
event_work->ver = ver;
|
||||
event_work->notify_id = notify_id;
|
||||
event_work->opcode = opcode;
|
||||
if (!queue_work(osdc->notify_wq, &event_work->work)) {
|
||||
dout("WARNING: failed to queue notify event work\n");
|
||||
goto done_err;
|
||||
}
|
||||
|
||||
queue_work(osdc->notify_wq, &event_work->work);
|
||||
}
|
||||
|
||||
return;
|
||||
|
||||
done_err:
|
||||
ceph_osdc_put_event(event);
|
||||
return;
|
||||
|
||||
bad:
|
||||
pr_err("osdc handle_watch_notify corrupt msg\n");
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче