ASoC: tas6424: Print full register name in error message
The current short version of the register name may be ambiguous when another fault register detection is added. Use the full name. While here fix comment about clearing faults, the CLEAR_FAULT register actually only clears sticky bits, which are only warnings, fault bits can only cleared by resolving the fault. Signed-off-by: Andrew F. Davis <afd@ti.com> Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Родитель
c2f0898b86
Коммит
919869214b
|
@ -408,7 +408,7 @@ static void tas6424_fault_check_work(struct work_struct *work)
|
|||
|
||||
ret = regmap_read(tas6424->regmap, TAS6424_GLOB_FAULT1, ®);
|
||||
if (ret < 0) {
|
||||
dev_err(dev, "failed to read FAULT1 register: %d\n", ret);
|
||||
dev_err(dev, "failed to read GLOB_FAULT1 register: %d\n", ret);
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
@ -451,7 +451,7 @@ static void tas6424_fault_check_work(struct work_struct *work)
|
|||
check_global_fault2_reg:
|
||||
ret = regmap_read(tas6424->regmap, TAS6424_GLOB_FAULT2, ®);
|
||||
if (ret < 0) {
|
||||
dev_err(dev, "failed to read FAULT2 register: %d\n", ret);
|
||||
dev_err(dev, "failed to read GLOB_FAULT2 register: %d\n", ret);
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
@ -524,7 +524,7 @@ check_warn_reg:
|
|||
/* Store current warn value so we can detect any changes next time */
|
||||
tas6424->last_warn = reg;
|
||||
|
||||
/* Clear any faults by toggling the CLEAR_FAULT control bit */
|
||||
/* Clear any warnings by toggling the CLEAR_FAULT control bit */
|
||||
ret = regmap_write_bits(tas6424->regmap, TAS6424_MISC_CTRL3,
|
||||
TAS6424_CLEAR_FAULT, TAS6424_CLEAR_FAULT);
|
||||
if (ret < 0)
|
||||
|
|
Загрузка…
Ссылка в новой задаче