w1: use octal for file permissions
Improve code readability and checkpatch warnings: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20230415104304.104134-6-krzysztof.kozlowski@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
ad9c36be1f
Коммит
921e0f2fb0
|
@ -36,7 +36,7 @@ MODULE_PARM_DESC(active_pullup, "Active pullup (apply to all buses): " \
|
|||
|
||||
/* extra configurations - e.g. 1WS */
|
||||
static int extra_config;
|
||||
module_param(extra_config, int, S_IRUGO | S_IWUSR);
|
||||
module_param(extra_config, int, 0644);
|
||||
MODULE_PARM_DESC(extra_config, "Extra Configuration settings 1=APU,2=PPM,3=SPU,8=1WS");
|
||||
|
||||
/*
|
||||
|
|
|
@ -48,7 +48,7 @@
|
|||
static DECLARE_WAIT_QUEUE_HEAD(hdq_wait_queue);
|
||||
|
||||
static int w1_id;
|
||||
module_param(w1_id, int, S_IRUSR);
|
||||
module_param(w1_id, int, 0400);
|
||||
MODULE_PARM_DESC(w1_id, "1-wire id for the slave detection in HDQ mode");
|
||||
|
||||
struct hdq_data {
|
||||
|
|
|
@ -99,7 +99,7 @@ static struct bin_attribute w1_f12_sysfs_bin_files[NB_SYSFS_BIN_FILES] = {
|
|||
{
|
||||
.attr = {
|
||||
.name = "state",
|
||||
.mode = S_IRUGO,
|
||||
.mode = 0444,
|
||||
},
|
||||
.size = 1,
|
||||
.read = w1_f12_read_state,
|
||||
|
@ -107,7 +107,7 @@ static struct bin_attribute w1_f12_sysfs_bin_files[NB_SYSFS_BIN_FILES] = {
|
|||
{
|
||||
.attr = {
|
||||
.name = "output",
|
||||
.mode = S_IRUGO | S_IWUSR | S_IWGRP,
|
||||
.mode = 0664,
|
||||
},
|
||||
.size = 1,
|
||||
.write = w1_f12_write_output,
|
||||
|
|
|
@ -128,7 +128,7 @@ out:
|
|||
return bytes_written;
|
||||
}
|
||||
|
||||
static BIN_ATTR(output, S_IRUGO | S_IWUSR | S_IWGRP, NULL, output_write, 1);
|
||||
static BIN_ATTR(output, 0664, NULL, output_write, 1);
|
||||
|
||||
static struct bin_attribute *w1_f3a_bin_attrs[] = {
|
||||
&bin_attr_state,
|
||||
|
|
|
@ -264,7 +264,7 @@ out_up:
|
|||
static struct bin_attribute w1_f0d_bin_attr = {
|
||||
.attr = {
|
||||
.name = "eeprom",
|
||||
.mode = S_IRUGO | S_IWUSR,
|
||||
.mode = 0644,
|
||||
},
|
||||
.size = W1_F0D_EEPROM_SIZE,
|
||||
.read = w1_f0d_read_bin,
|
||||
|
|
|
@ -31,12 +31,12 @@ MODULE_ALIAS("w1-family-" __stringify(W1_FAMILY_DS28E17));
|
|||
|
||||
/* Default I2C speed to be set when a DS28E17 is detected. */
|
||||
static int i2c_speed = 100;
|
||||
module_param_named(speed, i2c_speed, int, (S_IRUSR | S_IWUSR));
|
||||
module_param_named(speed, i2c_speed, int, 0600);
|
||||
MODULE_PARM_DESC(speed, "Default I2C speed to be set when a DS28E17 is detected");
|
||||
|
||||
/* Default I2C stretch value to be set when a DS28E17 is detected. */
|
||||
static char i2c_stretch = 1;
|
||||
module_param_named(stretch, i2c_stretch, byte, (S_IRUSR | S_IWUSR));
|
||||
module_param_named(stretch, i2c_stretch, byte, 0600);
|
||||
MODULE_PARM_DESC(stretch, "Default I2C stretch value to be set when a DS28E17 is detected");
|
||||
|
||||
/* DS28E17 device command codes. */
|
||||
|
|
Загрузка…
Ссылка в новой задаче