power: supply: qcom_battmgr: remove bogus do_div()
The argument to do_div() is a 32-bit integer, and it was read from a 32-bit register so there is no point in doing a 64-bit division on it. On 32-bit arm, do_div() causes a compile-time warning here: include/asm-generic/div64.h:238:22: error: passing argument 1 of '__div64_32' from incompatible pointer type [-Werror=incompatible-pointer-types] 238 | __rem = __div64_32(&(n), __base); \ | ^~~~ | | | unsigned int * drivers/power/supply/qcom_battmgr.c:1130:4: note: in expansion of macro 'do_div' 1130 | do_div(battmgr->status.percent, 100); Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Родитель
f122a08b19
Коммит
92304df83b
|
@ -1126,8 +1126,7 @@ static void qcom_battmgr_sm8350_callback(struct qcom_battmgr *battmgr,
|
|||
battmgr->info.charge_type = le32_to_cpu(resp->intval.value);
|
||||
break;
|
||||
case BATT_CAPACITY:
|
||||
battmgr->status.percent = le32_to_cpu(resp->intval.value);
|
||||
do_div(battmgr->status.percent, 100);
|
||||
battmgr->status.percent = le32_to_cpu(resp->intval.value) / 100;
|
||||
break;
|
||||
case BATT_VOLT_OCV:
|
||||
battmgr->status.voltage_ocv = le32_to_cpu(resp->intval.value);
|
||||
|
|
Загрузка…
Ссылка в новой задаче