HID: sony: validate HID output report details
This driver must validate the availability of the HID output report and its size before it can write LED states via buzz_set_leds(). This stops a heap overflow that is possible if a device provides a malicious HID output report: [ 108.171280] usb 1-1: New USB device found, idVendor=054c, idProduct=0002 ... [ 117.507877] BUG kmalloc-192 (Not tainted): Redzone overwritten CVE-2013-2890 Signed-off-by: Kees Cook <keescook@chromium.org> Cc: stable@vger.kernel.org #3.11 Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Родитель
78214e81a1
Коммит
9446edb9a1
|
@ -537,6 +537,10 @@ static int buzz_init(struct hid_device *hdev)
|
|||
drv_data = hid_get_drvdata(hdev);
|
||||
BUG_ON(!(drv_data->quirks & BUZZ_CONTROLLER));
|
||||
|
||||
/* Validate expected report characteristics. */
|
||||
if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 0, 0, 7))
|
||||
return -ENODEV;
|
||||
|
||||
buzz = kzalloc(sizeof(*buzz), GFP_KERNEL);
|
||||
if (!buzz) {
|
||||
hid_err(hdev, "Insufficient memory, cannot allocate driver data\n");
|
||||
|
|
Загрузка…
Ссылка в новой задаче