ASoC: rt5651: Use IRQF_NO_AUTOEN when requesting the IRQ
[ Upstream commit 6e037b72cf
]
Use the new IRQF_NO_AUTOEN flag when requesting the IRQ, rather then
disabling it immediately after requesting it.
This fixes a possible race where the IRQ might trigger between requesting
and disabling it; and this also leads to a small code cleanup.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211003132255.31743-2-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Родитель
0864d7f686
Коммит
94ca62033d
|
@ -2261,11 +2261,8 @@ static int rt5651_i2c_probe(struct i2c_client *i2c,
|
|||
|
||||
ret = devm_request_irq(&i2c->dev, rt5651->irq, rt5651_irq,
|
||||
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING
|
||||
| IRQF_ONESHOT, "rt5651", rt5651);
|
||||
if (ret == 0) {
|
||||
/* Gets re-enabled by rt5651_set_jack() */
|
||||
disable_irq(rt5651->irq);
|
||||
} else {
|
||||
| IRQF_ONESHOT | IRQF_NO_AUTOEN, "rt5651", rt5651);
|
||||
if (ret) {
|
||||
dev_warn(&i2c->dev, "Failed to reguest IRQ %d: %d\n",
|
||||
rt5651->irq, ret);
|
||||
rt5651->irq = -ENXIO;
|
||||
|
|
Загрузка…
Ссылка в новой задаче