gpiolib: fix chip order in gpio list

In some situations the gpio_list order is not correct.
As a consequence gpiochip_find_base returns the same
base number twice. This happens when a first ship is added
with manual base number, then other ships are added using
automatic base number.

To prevent this behaviour, this patch add the new chip after
the last element of the gpio list.

Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Julien Grossholtz 2016-01-07 16:46:45 -05:00 коммит произвёл Linus Walleij
Родитель 78179989a0
Коммит 96098df125
1 изменённых файлов: 4 добавлений и 2 удалений

Просмотреть файл

@ -226,8 +226,10 @@ static int gpiochip_add_to_list(struct gpio_chip *chip)
*/ */
iterator = list_last_entry(&gpio_chips, struct gpio_chip, list); iterator = list_last_entry(&gpio_chips, struct gpio_chip, list);
if (iterator->base + iterator->ngpio <= chip->base) if (iterator->base + iterator->ngpio <= chip->base) {
goto found; list_add(&chip->list, &iterator->list);
return 0;
}
dev_err(chip->parent, dev_err(chip->parent,
"GPIO integer space overlap, cannot add chip\n"); "GPIO integer space overlap, cannot add chip\n");