drm/rockchip: dw-mipi-dsi: allow commands in panel_disable
Panel drivers may want to sent commands during the disable function, for example MIPI_DCS_SET_DISPLAY_OFF before the video signal ends. In order to send commands we need to write to registers, so pclk must be enabled. While changing this, remove the unnecessary code after the panel unprepare call which seems to be a workaround for a specific panel and thus belongs in the panel driver. Signed-off-by: John Keeping <john@metanate.com> Reviewed-by: Chris Zhong <zyw@rock-chips.com> Reviewed-by: Sean Paul <seanpaul@chromium.org> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: http://patchwork.freedesktop.org/patch/msgid/20170224125506.21533-13-john@metanate.com
This commit is contained in:
Родитель
8a7df73ff9
Коммит
96ad6f0b8d
|
@ -848,24 +848,16 @@ static void dw_mipi_dsi_encoder_disable(struct drm_encoder *encoder)
|
|||
{
|
||||
struct dw_mipi_dsi *dsi = encoder_to_dsi(encoder);
|
||||
|
||||
drm_panel_disable(dsi->panel);
|
||||
|
||||
if (clk_prepare_enable(dsi->pclk)) {
|
||||
dev_err(dsi->dev, "%s: Failed to enable pclk\n", __func__);
|
||||
return;
|
||||
}
|
||||
|
||||
drm_panel_disable(dsi->panel);
|
||||
|
||||
dw_mipi_dsi_set_mode(dsi, DW_MIPI_DSI_CMD_MODE);
|
||||
drm_panel_unprepare(dsi->panel);
|
||||
dw_mipi_dsi_set_mode(dsi, DW_MIPI_DSI_VID_MODE);
|
||||
|
||||
/*
|
||||
* This is necessary to make sure the peripheral will be driven
|
||||
* normally when the display is enabled again later.
|
||||
*/
|
||||
msleep(120);
|
||||
|
||||
dw_mipi_dsi_set_mode(dsi, DW_MIPI_DSI_CMD_MODE);
|
||||
dw_mipi_dsi_disable(dsi);
|
||||
clk_disable_unprepare(dsi->pclk);
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче