ufs: ensure clk gating work is finished before module unloading
When dynamic clk gating feature is enabled, delayed workqueue machanism is used in order to detect certain period of inactivity. But there is no guarantee that scheduled gating work is completed before module unloading. So it can cause kernel crash by accessing memory after it was freed. Fix it by cancelling clk gating and ungating works and ensure that its execution is finished before module unloading. Signed-off-by: Akinobu Mita <mita@fixstars.com> Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org> Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Родитель
e8cb64db81
Коммит
97cd6805ac
|
@ -744,6 +744,8 @@ static void ufshcd_exit_clk_gating(struct ufs_hba *hba)
|
||||||
if (!ufshcd_is_clkgating_allowed(hba))
|
if (!ufshcd_is_clkgating_allowed(hba))
|
||||||
return;
|
return;
|
||||||
device_remove_file(hba->dev, &hba->clk_gating.delay_attr);
|
device_remove_file(hba->dev, &hba->clk_gating.delay_attr);
|
||||||
|
cancel_work_sync(&hba->clk_gating.ungate_work);
|
||||||
|
cancel_delayed_work_sync(&hba->clk_gating.gate_work);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Must be called with host lock acquired */
|
/* Must be called with host lock acquired */
|
||||||
|
|
Загрузка…
Ссылка в новой задаче