btrfs: forbid deleting live subvol qgroup
commit a8df35619948bd8363d330c20a90c9a7fbff28c0 upstream. If a subvolume still exists, forbid deleting its qgroup 0/subvolid. This behavior generally leads to incorrect behavior in squotas and doesn't have a legitimate purpose. Fixes: cecbb533b5fc ("btrfs: record simple quota deltas in delayed refs") CC: stable@vger.kernel.org # 5.4+ Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Boris Burkov <boris@bur.io> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
e31546b0f3
Коммит
980e2bee30
|
@ -1608,6 +1608,15 @@ out:
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static bool qgroup_has_usage(struct btrfs_qgroup *qgroup)
|
||||||
|
{
|
||||||
|
return (qgroup->rfer > 0 || qgroup->rfer_cmpr > 0 ||
|
||||||
|
qgroup->excl > 0 || qgroup->excl_cmpr > 0 ||
|
||||||
|
qgroup->rsv.values[BTRFS_QGROUP_RSV_DATA] > 0 ||
|
||||||
|
qgroup->rsv.values[BTRFS_QGROUP_RSV_META_PREALLOC] > 0 ||
|
||||||
|
qgroup->rsv.values[BTRFS_QGROUP_RSV_META_PERTRANS] > 0);
|
||||||
|
}
|
||||||
|
|
||||||
int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, u64 qgroupid)
|
int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, u64 qgroupid)
|
||||||
{
|
{
|
||||||
struct btrfs_fs_info *fs_info = trans->fs_info;
|
struct btrfs_fs_info *fs_info = trans->fs_info;
|
||||||
|
@ -1627,6 +1636,11 @@ int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, u64 qgroupid)
|
||||||
goto out;
|
goto out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (is_fstree(qgroupid) && qgroup_has_usage(qgroup)) {
|
||||||
|
ret = -EBUSY;
|
||||||
|
goto out;
|
||||||
|
}
|
||||||
|
|
||||||
/* Check if there are no children of this qgroup */
|
/* Check if there are no children of this qgroup */
|
||||||
if (!list_empty(&qgroup->members)) {
|
if (!list_empty(&qgroup->members)) {
|
||||||
ret = -EBUSY;
|
ret = -EBUSY;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче