ASoC: mediatek: mt8173-rt5650: Fix refcount leak in mt8173_rt5650_dev_probe
[ Upstream commitefe2178d1a
] of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Fix refcount leak in some error paths. Fixes:0f83f9296d
("ASoC: mediatek: Add machine driver for ALC5650 codec") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220603124243.31358-1-linmq006@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Родитель
542861e5e2
Коммит
994f2edeeb
|
@ -280,7 +280,8 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev)
|
|||
if (!mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node) {
|
||||
dev_err(&pdev->dev,
|
||||
"Property 'audio-codec' missing or invalid\n");
|
||||
return -EINVAL;
|
||||
ret = -EINVAL;
|
||||
goto put_platform_node;
|
||||
}
|
||||
mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[1].of_node =
|
||||
mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[0].of_node;
|
||||
|
@ -293,7 +294,7 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev)
|
|||
dev_err(&pdev->dev,
|
||||
"%s codec_capture_dai name fail %d\n",
|
||||
__func__, ret);
|
||||
return ret;
|
||||
goto put_platform_node;
|
||||
}
|
||||
mt8173_rt5650_dais[DAI_LINK_CODEC_I2S].codecs[1].dai_name =
|
||||
codec_capture_dai;
|
||||
|
@ -315,7 +316,8 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev)
|
|||
if (!mt8173_rt5650_dais[DAI_LINK_HDMI_I2S].codecs->of_node) {
|
||||
dev_err(&pdev->dev,
|
||||
"Property 'audio-codec' missing or invalid\n");
|
||||
return -EINVAL;
|
||||
ret = -EINVAL;
|
||||
goto put_platform_node;
|
||||
}
|
||||
card->dev = &pdev->dev;
|
||||
|
||||
|
@ -324,6 +326,7 @@ static int mt8173_rt5650_dev_probe(struct platform_device *pdev)
|
|||
dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n",
|
||||
__func__, ret);
|
||||
|
||||
put_platform_node:
|
||||
of_node_put(platform_node);
|
||||
return ret;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче