rtc: mc13xxx: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230304133028.2135435-17-u.kleine-koenig@pengutronix.de Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Родитель
bf05de0116
Коммит
99c3a1367d
|
@ -324,7 +324,7 @@ err_irq_request:
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int mc13xxx_rtc_remove(struct platform_device *pdev)
|
static void mc13xxx_rtc_remove(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
struct mc13xxx_rtc *priv = platform_get_drvdata(pdev);
|
struct mc13xxx_rtc *priv = platform_get_drvdata(pdev);
|
||||||
|
|
||||||
|
@ -334,8 +334,6 @@ static int mc13xxx_rtc_remove(struct platform_device *pdev)
|
||||||
mc13xxx_irq_free(priv->mc13xxx, MC13XXX_IRQ_RTCRST, priv);
|
mc13xxx_irq_free(priv->mc13xxx, MC13XXX_IRQ_RTCRST, priv);
|
||||||
|
|
||||||
mc13xxx_unlock(priv->mc13xxx);
|
mc13xxx_unlock(priv->mc13xxx);
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static const struct platform_device_id mc13xxx_rtc_idtable[] = {
|
static const struct platform_device_id mc13xxx_rtc_idtable[] = {
|
||||||
|
@ -352,7 +350,7 @@ MODULE_DEVICE_TABLE(platform, mc13xxx_rtc_idtable);
|
||||||
|
|
||||||
static struct platform_driver mc13xxx_rtc_driver = {
|
static struct platform_driver mc13xxx_rtc_driver = {
|
||||||
.id_table = mc13xxx_rtc_idtable,
|
.id_table = mc13xxx_rtc_idtable,
|
||||||
.remove = mc13xxx_rtc_remove,
|
.remove_new = mc13xxx_rtc_remove,
|
||||||
.driver = {
|
.driver = {
|
||||||
.name = DRIVER_NAME,
|
.name = DRIVER_NAME,
|
||||||
},
|
},
|
||||||
|
|
Загрузка…
Ссылка в новой задаче