staging: comedi: pcl726: use comedi_request_region()

Use comedi_request_region() to request the I/O region used by this
driver.

Remove the noise when the board is first attached as well as the
error message when the request_region() fails, comedi_request_reqion()
will output the error message if necessary.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-04-09 16:08:44 -07:00 коммит произвёл Greg Kroah-Hartman
Родитель 44a6438bbe
Коммит 99c671a636
1 изменённых файлов: 3 добавлений и 12 удалений

Просмотреть файл

@ -225,23 +225,14 @@ static int pcl726_attach(struct comedi_device *dev, struct comedi_devconfig *it)
const struct pcl726_board *board = comedi_board(dev); const struct pcl726_board *board = comedi_board(dev);
struct pcl726_private *devpriv; struct pcl726_private *devpriv;
struct comedi_subdevice *s; struct comedi_subdevice *s;
unsigned long iobase;
unsigned int iorange;
int ret, i; int ret, i;
#ifdef ACL6126_IRQ #ifdef ACL6126_IRQ
unsigned int irq; unsigned int irq;
#endif #endif
iobase = it->options[0]; ret = comedi_request_region(dev, it->options[0], board->io_range);
iorange = board->io_range; if (ret)
printk(KERN_WARNING "comedi%d: pcl726: board=%s, 0x%03lx ", dev->minor, return ret;
board->name, iobase);
if (!request_region(iobase, iorange, dev->board_name)) {
printk(KERN_WARNING "I/O port conflict\n");
return -EIO;
}
dev->iobase = iobase;
devpriv = kzalloc(sizeof(*devpriv), GFP_KERNEL); devpriv = kzalloc(sizeof(*devpriv), GFP_KERNEL);
if (!devpriv) if (!devpriv)