NFC: pn544: Switch to devm_acpi_dev_add_driver_gpios()
Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify error path and fix potentially wrong assignment if ->probe() fails. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Родитель
e33a3f84f8
Коммит
99f2064e15
|
@ -904,7 +904,7 @@ static int pn544_hci_i2c_probe(struct i2c_client *client,
|
||||||
phy->i2c_dev = client;
|
phy->i2c_dev = client;
|
||||||
i2c_set_clientdata(client, phy);
|
i2c_set_clientdata(client, phy);
|
||||||
|
|
||||||
r = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev), acpi_pn544_gpios);
|
r = devm_acpi_dev_add_driver_gpios(dev, acpi_pn544_gpios);
|
||||||
if (r)
|
if (r)
|
||||||
dev_dbg(dev, "Unable to add GPIO mapping table\n");
|
dev_dbg(dev, "Unable to add GPIO mapping table\n");
|
||||||
|
|
||||||
|
@ -958,7 +958,6 @@ static int pn544_hci_i2c_remove(struct i2c_client *client)
|
||||||
if (phy->powered)
|
if (phy->powered)
|
||||||
pn544_hci_i2c_disable(phy);
|
pn544_hci_i2c_disable(phy);
|
||||||
|
|
||||||
acpi_dev_remove_driver_gpios(ACPI_COMPANION(&client->dev));
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче