[NET]: Fully fix the memory leaks in sys_accept().
Andi Kleen was right, fput() on sock->file will end up calling sock_release() if necessary. So here is the rest of his version of the fix for these leaks. Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Родитель
2722971cbe
Коммит
9a1875e60e
|
@ -1418,7 +1418,8 @@ asmlinkage long sys_accept(int fd, struct sockaddr __user *upeer_sockaddr, int _
|
|||
newfd = sock_alloc_fd(&newfile);
|
||||
if (unlikely(newfd < 0)) {
|
||||
err = newfd;
|
||||
goto out_release;
|
||||
sock_release(newsock);
|
||||
goto out_put;
|
||||
}
|
||||
|
||||
err = sock_attach_fd(newsock, newfile);
|
||||
|
@ -1457,8 +1458,6 @@ out:
|
|||
out_fd:
|
||||
fput(newfile);
|
||||
put_unused_fd(newfd);
|
||||
out_release:
|
||||
sock_release(newsock);
|
||||
goto out_put;
|
||||
}
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче