media: i2c: imx274: fix error return code of imx274_s_frame_interval()
When __v4l2_ctrl_modify_range() fails, no error return code of imx274_s_frame_interval() is assigned. To fix this bug, ret is assigned with the return valye of __v4l2_ctrl_modify_range(), and then ret is checked. Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Родитель
a7de6eac6f
Коммит
9a4619ef6c
|
@ -1381,7 +1381,8 @@ static int imx274_s_frame_interval(struct v4l2_subdev *sd,
|
|||
max = fi->interval.numerator * 1000000
|
||||
/ fi->interval.denominator;
|
||||
def = max;
|
||||
if (__v4l2_ctrl_modify_range(ctrl, min, max, 1, def)) {
|
||||
ret = __v4l2_ctrl_modify_range(ctrl, min, max, 1, def);
|
||||
if (ret) {
|
||||
dev_err(&imx274->client->dev,
|
||||
"Exposure ctrl range update failed\n");
|
||||
goto unlock;
|
||||
|
|
Загрузка…
Ссылка в новой задаче