sysctl: remove redundant assignment to first

Variable first is set to '0', but this value is never read as it is not
used later on, hence it is a redundant assignment and can be removed.

Clean up the following clang-analyzer warning:

kernel/sysctl.c:1562:4: warning: Value stored to 'first' is never read
[clang-analyzer-deadcode.DeadStores].

Link: https://lkml.kernel.org/r/1620469990-22182-1-git-send-email-jiapeng.chong@linux.alibaba.com
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Iurii Zaikin <yzaikin@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Martin KaFai Lau <kafai@fb.com>
Cc: Song Liu <songliubraving@fb.com>
Cc: Yonghong Song <yhs@fb.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: KP Singh <kpsingh@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jiapeng Chong 2021-06-30 18:54:53 -07:00 коммит произвёл Linus Torvalds
Родитель 3845f256a8
Коммит 9a52c5f3c8
1 изменённых файлов: 1 добавлений и 2 удалений

Просмотреть файл

@ -1494,7 +1494,6 @@ int proc_do_large_bitmap(struct ctl_table *table, int write,
void *buffer, size_t *lenp, loff_t *ppos) void *buffer, size_t *lenp, loff_t *ppos)
{ {
int err = 0; int err = 0;
bool first = 1;
size_t left = *lenp; size_t left = *lenp;
unsigned long bitmap_len = table->maxlen; unsigned long bitmap_len = table->maxlen;
unsigned long *bitmap = *(unsigned long **) table->data; unsigned long *bitmap = *(unsigned long **) table->data;
@ -1579,12 +1578,12 @@ int proc_do_large_bitmap(struct ctl_table *table, int write,
} }
bitmap_set(tmp_bitmap, val_a, val_b - val_a + 1); bitmap_set(tmp_bitmap, val_a, val_b - val_a + 1);
first = 0;
proc_skip_char(&p, &left, '\n'); proc_skip_char(&p, &left, '\n');
} }
left += skipped; left += skipped;
} else { } else {
unsigned long bit_a, bit_b = 0; unsigned long bit_a, bit_b = 0;
bool first = 1;
while (left) { while (left) {
bit_a = find_next_bit(bitmap, bitmap_len, bit_b); bit_a = find_next_bit(bitmap, bitmap_len, bit_b);