From 9ad14c001651955ebc390a5bb56858b0ee27ec2d Mon Sep 17 00:00:00 2001 From: Viresh Kumar Date: Thu, 24 May 2018 16:02:40 +0530 Subject: [PATCH] PM / Domain: Return 0 on error from of_genpd_opp_to_performance_state() of_genpd_opp_to_performance_state() should return 0 on errors, as its doc comment describes. While it follows that mostly, it returns a negative error number on one of the failures. Fix that. Fixes: 6e41766a6a50 "PM / Domain: Implement of_genpd_opp_to_performance_state()" Reported-by: Rajendra Nayak Signed-off-by: Viresh Kumar Acked-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki --- drivers/base/power/domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index da6c8860c72e..71a1cc79fbaa 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2431,7 +2431,8 @@ unsigned int of_genpd_opp_to_performance_state(struct device *dev, opp = of_dev_pm_opp_find_required_opp(&genpd->dev, opp_node); if (IS_ERR(opp)) { - state = PTR_ERR(opp); + dev_err(dev, "Failed to find required OPP: %ld\n", + PTR_ERR(opp)); goto unlock; }