ASoC: SOF: topology: Fix memory leak in sof_control_load()
scontrol doesn't get freed when kstrdup returns NULL. Fix by free iscontrol in that case. scontrol = kzalloc(sizeof(*scontrol), GFP_KERNEL); if (!scontrol) return -ENOMEM; scontrol->name = kstrdup(hdr->name, GFP_KERNEL); if (!scontrol->name) return -ENOMEM; Signed-off-by: Yu Liao <liaoyu15@huawei.com> Link: https://lore.kernel.org/r/20220318021616.2599630-1-liaoyu15@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Родитель
20744617bd
Коммит
9b91d0ece2
|
@ -904,8 +904,10 @@ static int sof_control_load(struct snd_soc_component *scomp, int index,
|
|||
return -ENOMEM;
|
||||
|
||||
scontrol->name = kstrdup(hdr->name, GFP_KERNEL);
|
||||
if (!scontrol->name)
|
||||
if (!scontrol->name) {
|
||||
kfree(scontrol);
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
scontrol->scomp = scomp;
|
||||
scontrol->access = kc->access;
|
||||
|
|
Загрузка…
Ссылка в новой задаче