dmaengine: xgene: devm_ioremap() returns NULL on error

The code here is checking for IS_ERR() but devm_ioremap() returns NULL
on error and not an error pointer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
Dan Carpenter 2015-04-09 12:03:31 +03:00 коммит произвёл Vinod Koul
Родитель ed1f041842
Коммит 9c361b1afd
1 изменённых файлов: 8 добавлений и 8 удалений

Просмотреть файл

@ -1895,9 +1895,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev,
pdma->csr_dma = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
if (IS_ERR(pdma->csr_dma)) {
if (!pdma->csr_dma) {
dev_err(&pdev->dev, "Failed to ioremap csr region");
return PTR_ERR(pdma->csr_dma);
return -ENOMEM;
}
/* Get DMA ring csr region */
@ -1909,9 +1909,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev,
pdma->csr_ring = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
if (IS_ERR(pdma->csr_ring)) {
if (!pdma->csr_ring) {
dev_err(&pdev->dev, "Failed to ioremap ring csr region");
return PTR_ERR(pdma->csr_ring);
return -ENOMEM;
}
/* Get DMA ring cmd csr region */
@ -1923,9 +1923,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev,
pdma->csr_ring_cmd = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
if (IS_ERR(pdma->csr_ring_cmd)) {
if (!pdma->csr_ring_cmd) {
dev_err(&pdev->dev, "Failed to ioremap ring cmd csr region");
return PTR_ERR(pdma->csr_ring_cmd);
return -ENOMEM;
}
/* Get efuse csr region */
@ -1937,9 +1937,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev,
pdma->csr_efuse = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
if (IS_ERR(pdma->csr_efuse)) {
if (!pdma->csr_efuse) {
dev_err(&pdev->dev, "Failed to ioremap efuse csr region");
return PTR_ERR(pdma->csr_efuse);
return -ENOMEM;
}
/* Get DMA error interrupt */