"xfs: fix error handling for synchronous writes" revisited
xfs: fix for hang during synchronous buffer write error
If removed storage while synchronous buffer write underway,
"xfslogd" hangs.
Detailed log http://oss.sgi.com/archives/xfs/2011-07/msg00740.html
Related work bfc60177f8
"xfs: fix error handling for synchronous writes"
Given that xfs_bwrite actually does the shutdown already after
waiting for the b_iodone completion and given that we actually
found that calling xfs_force_shutdown from inside
xfs_buf_iodone_callbacks was a major contributor the problem
it better to drop this call.
Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
This commit is contained in:
Родитель
e44f4112a4
Коммит
9e978d8f7d
|
@ -1010,7 +1010,6 @@ xfs_buf_iodone_callbacks(
|
||||||
XFS_BUF_UNDELAYWRITE(bp);
|
XFS_BUF_UNDELAYWRITE(bp);
|
||||||
|
|
||||||
trace_xfs_buf_error_relse(bp, _RET_IP_);
|
trace_xfs_buf_error_relse(bp, _RET_IP_);
|
||||||
xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);
|
|
||||||
|
|
||||||
do_callbacks:
|
do_callbacks:
|
||||||
xfs_buf_do_callbacks(bp);
|
xfs_buf_do_callbacks(bp);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче