kdb: kdb_main: refactor code in kdb_md_line
Replace the whole switch statement with a for loop. This makes the code clearer and easy to read. This also addresses the following Coverity warnings: Addresses-Coverity-ID: 115090 ("Missing break in switch") Addresses-Coverity-ID: 115091 ("Missing break in switch") Addresses-Coverity-ID: 114700 ("Missing break in switch") Suggested-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> [daniel.thompson@linaro.org: Tiny grammar change in description] Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
This commit is contained in:
Родитель
c2b94c72d9
Коммит
9eb62f0e1b
|
@ -1493,6 +1493,7 @@ static void kdb_md_line(const char *fmtstr, unsigned long addr,
|
|||
char cbuf[32];
|
||||
char *c = cbuf;
|
||||
int i;
|
||||
int j;
|
||||
unsigned long word;
|
||||
|
||||
memset(cbuf, '\0', sizeof(cbuf));
|
||||
|
@ -1538,25 +1539,9 @@ static void kdb_md_line(const char *fmtstr, unsigned long addr,
|
|||
wc.word = word;
|
||||
#define printable_char(c) \
|
||||
({unsigned char __c = c; isascii(__c) && isprint(__c) ? __c : '.'; })
|
||||
switch (bytesperword) {
|
||||
case 8:
|
||||
for (j = 0; j < bytesperword; j++)
|
||||
*c++ = printable_char(*cp++);
|
||||
*c++ = printable_char(*cp++);
|
||||
*c++ = printable_char(*cp++);
|
||||
*c++ = printable_char(*cp++);
|
||||
addr += 4;
|
||||
case 4:
|
||||
*c++ = printable_char(*cp++);
|
||||
*c++ = printable_char(*cp++);
|
||||
addr += 2;
|
||||
case 2:
|
||||
*c++ = printable_char(*cp++);
|
||||
addr++;
|
||||
case 1:
|
||||
*c++ = printable_char(*cp++);
|
||||
addr++;
|
||||
break;
|
||||
}
|
||||
addr += bytesperword;
|
||||
#undef printable_char
|
||||
}
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче