GFS2: Use new workqueue scheme
The recovery workqueue can be freezable since we want it to finish what it is doing if the system is to be frozen (although why you'd want to freeze a cluster node is beyond me since it will result in it being ejected from the cluster). It does still make sense for single node GFS2 filesystems though. The glock workqueue will benefit from being able to run more work items concurrently. A test running postmark shows improved performance and multi-threaded workloads are likely to benefit even more. It needs to be high priority because the latency directly affects the latency of filesystem glock operations. The delete workqueue is similar to the recovery workqueue in that it must not get blocked by memory allocations, and may run for a long time. Potentially other GFS2 threads might also be converted to workqueues, but I'll leave that for a later patch. Signed-off-by: Steven Whitehouse <swhiteho@redhat.com> Acked-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
Родитель
1fea7c25a0
Коммит
9fa0ea9f26
|
@ -1783,10 +1783,12 @@ int __init gfs2_glock_init(void)
|
|||
}
|
||||
#endif
|
||||
|
||||
glock_workqueue = create_workqueue("glock_workqueue");
|
||||
glock_workqueue = alloc_workqueue("glock_workqueue", WQ_RESCUER |
|
||||
WQ_HIGHPRI | WQ_FREEZEABLE, 0);
|
||||
if (IS_ERR(glock_workqueue))
|
||||
return PTR_ERR(glock_workqueue);
|
||||
gfs2_delete_workqueue = create_workqueue("delete_workqueue");
|
||||
gfs2_delete_workqueue = alloc_workqueue("delete_workqueue", WQ_RESCUER |
|
||||
WQ_FREEZEABLE, 0);
|
||||
if (IS_ERR(gfs2_delete_workqueue)) {
|
||||
destroy_workqueue(glock_workqueue);
|
||||
return PTR_ERR(gfs2_delete_workqueue);
|
||||
|
|
|
@ -140,7 +140,7 @@ static int __init init_gfs2_fs(void)
|
|||
|
||||
error = -ENOMEM;
|
||||
gfs_recovery_wq = alloc_workqueue("gfs_recovery",
|
||||
WQ_NON_REENTRANT | WQ_RESCUER, 0);
|
||||
WQ_RESCUER | WQ_FREEZEABLE, 0);
|
||||
if (!gfs_recovery_wq)
|
||||
goto fail_wq;
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче