ASLA: ad1889: Remove always NULL parameter
snd_ad1889_pcm_init() takes a pointer to a pointer of a PCM where if this parameter is provided the newly allocated PCM is stored. All callers pass NULL though, so remove the parameter. This makes the code a bit cleaner and shorter. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Родитель
fa60c06569
Коммит
a08800940f
|
@ -623,14 +623,11 @@ snd_ad1889_interrupt(int irq, void *dev_id)
|
||||||
}
|
}
|
||||||
|
|
||||||
static int
|
static int
|
||||||
snd_ad1889_pcm_init(struct snd_ad1889 *chip, int device, struct snd_pcm **rpcm)
|
snd_ad1889_pcm_init(struct snd_ad1889 *chip, int device)
|
||||||
{
|
{
|
||||||
int err;
|
int err;
|
||||||
struct snd_pcm *pcm;
|
struct snd_pcm *pcm;
|
||||||
|
|
||||||
if (rpcm)
|
|
||||||
*rpcm = NULL;
|
|
||||||
|
|
||||||
err = snd_pcm_new(chip->card, chip->card->driver, device, 1, 1, &pcm);
|
err = snd_pcm_new(chip->card, chip->card->driver, device, 1, 1, &pcm);
|
||||||
if (err < 0)
|
if (err < 0)
|
||||||
return err;
|
return err;
|
||||||
|
@ -658,9 +655,6 @@ snd_ad1889_pcm_init(struct snd_ad1889 *chip, int device, struct snd_pcm **rpcm)
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (rpcm)
|
|
||||||
*rpcm = pcm;
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1016,7 +1010,7 @@ snd_ad1889_probe(struct pci_dev *pci,
|
||||||
if (err < 0)
|
if (err < 0)
|
||||||
goto free_and_ret;
|
goto free_and_ret;
|
||||||
|
|
||||||
err = snd_ad1889_pcm_init(chip, 0, NULL);
|
err = snd_ad1889_pcm_init(chip, 0);
|
||||||
if (err < 0)
|
if (err < 0)
|
||||||
goto free_and_ret;
|
goto free_and_ret;
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче