pinctrl: palmas: fix a possible NULL dereference
of_match_device could return NULL, and so cause a NULL pointer dereference later at line 1009: pinctrl_data = match->data; For fixing this problem, we use of_device_get_match_data(), this will simplify the code a little by using a standard function for getting the match data. Reported-by: coverity (CID 1324136) Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Родитель
26fecf0b21
Коммит
a1edf87f21
|
@ -1004,9 +1004,7 @@ static int palmas_pinctrl_probe(struct platform_device *pdev)
|
|||
bool enable_dvfs2 = false;
|
||||
|
||||
if (pdev->dev.of_node) {
|
||||
const struct of_device_id *match;
|
||||
match = of_match_device(palmas_pinctrl_of_match, &pdev->dev);
|
||||
pinctrl_data = match->data;
|
||||
pinctrl_data = of_device_get_match_data(&pdev->dev);
|
||||
enable_dvfs1 = of_property_read_bool(pdev->dev.of_node,
|
||||
"ti,palmas-enable-dvfs1");
|
||||
enable_dvfs2 = of_property_read_bool(pdev->dev.of_node,
|
||||
|
|
Загрузка…
Ссылка в новой задаче