USB: storage: ene_ub6250: Use kmemdup instead of kmalloc + memcpy
This issue was reported by coccicheck using the semantic patch at scripts/coccinelle/api/memdup.cocci Signed-off-by: Benoit Taine <benoit.taine@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Родитель
a7683eb3af
Коммит
a328512d3c
|
@ -1928,11 +1928,10 @@ static int ene_load_bincode(struct us_data *us, unsigned char flag)
|
|||
usb_stor_dbg(us, "load firmware %s failed\n", fw_name);
|
||||
goto nofw;
|
||||
}
|
||||
buf = kmalloc(sd_fw->size, GFP_KERNEL);
|
||||
buf = kmemdup(sd_fw->data, sd_fw->size, GFP_KERNEL);
|
||||
if (buf == NULL)
|
||||
goto nofw;
|
||||
|
||||
memcpy(buf, sd_fw->data, sd_fw->size);
|
||||
memset(bcb, 0, sizeof(struct bulk_cb_wrap));
|
||||
bcb->Signature = cpu_to_le32(US_BULK_CB_SIGN);
|
||||
bcb->DataTransferLength = sd_fw->size;
|
||||
|
|
Загрузка…
Ссылка в новой задаче