ahci: drop intx manipulation on msi enable
There's no need to turn off intx explicitly on msi enable. This is automatically handled by pci. Drop it. This might be needed on machines if the BIOS turns intx off during boot. However, there's no evidence of such behavior for ahci and the only such case seems to be ICH5 PATA according to ata_piix. Also, given the way ahci operates, it's highly unlikely BIOS ever disables IRQ for the controller. However, as this change has slight possibility of introducing failure, please schedule it for #upstream. Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
This commit is contained in:
Родитель
6be976e79d
Коммит
a5bfc4714b
|
@ -2647,8 +2647,8 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
|
||||||
if (board_id == board_ahci_sb700 && pdev->revision >= 0x40)
|
if (board_id == board_ahci_sb700 && pdev->revision >= 0x40)
|
||||||
hpriv->flags &= ~AHCI_HFLAG_IGN_SERR_INTERNAL;
|
hpriv->flags &= ~AHCI_HFLAG_IGN_SERR_INTERNAL;
|
||||||
|
|
||||||
if ((hpriv->flags & AHCI_HFLAG_NO_MSI) || pci_enable_msi(pdev))
|
if (!(hpriv->flags & AHCI_HFLAG_NO_MSI))
|
||||||
pci_intx(pdev, 1);
|
pci_enable_msi(pdev);
|
||||||
|
|
||||||
/* save initial config */
|
/* save initial config */
|
||||||
ahci_save_initial_config(pdev, hpriv);
|
ahci_save_initial_config(pdev, hpriv);
|
||||||
|
|
Загрузка…
Ссылка в новой задаче