PCI: rcar: Fix runtime PM imbalance on error
pm_runtime_get_sync() increments the runtime PM usage counter even
when the call returns an error code. Thus a corresponding decrement is
needed on the error handling path to keep the counter balanced.
Link: https://lore.kernel.org/r/20200709064356.8800-1-dinghao.liu@zju.edu.cn
Fixes: 0df6150e7c
("PCI: rcar: Use runtime PM to control controller clock")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
This commit is contained in:
Родитель
cb52a40202
Коммит
a68e06e729
|
@ -986,7 +986,7 @@ static int rcar_pcie_probe(struct platform_device *pdev)
|
||||||
err = pm_runtime_get_sync(pcie->dev);
|
err = pm_runtime_get_sync(pcie->dev);
|
||||||
if (err < 0) {
|
if (err < 0) {
|
||||||
dev_err(pcie->dev, "pm_runtime_get_sync failed\n");
|
dev_err(pcie->dev, "pm_runtime_get_sync failed\n");
|
||||||
goto err_pm_disable;
|
goto err_pm_put;
|
||||||
}
|
}
|
||||||
|
|
||||||
err = rcar_pcie_get_resources(host);
|
err = rcar_pcie_get_resources(host);
|
||||||
|
@ -1057,8 +1057,6 @@ err_unmap_msi_irqs:
|
||||||
|
|
||||||
err_pm_put:
|
err_pm_put:
|
||||||
pm_runtime_put(dev);
|
pm_runtime_put(dev);
|
||||||
|
|
||||||
err_pm_disable:
|
|
||||||
pm_runtime_disable(dev);
|
pm_runtime_disable(dev);
|
||||||
pci_free_resource_list(&host->resources);
|
pci_free_resource_list(&host->resources);
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче