media: tc358743: Fix error return code in tc358743_probe_of()
When the CSI bps per lane is not in the valid range, an appropriate error
code -EINVAL should be returned. However, we currently do not explicitly
assign this error code to 'ret'. As a result, 0 was incorrectly returned.
Fixes: 2561482468
("[media] tc358743: support probe from device tree")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Родитель
d67fa04ce4
Коммит
a6b1e7093f
|
@ -1974,6 +1974,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
|
||||||
bps_pr_lane = 2 * endpoint.link_frequencies[0];
|
bps_pr_lane = 2 * endpoint.link_frequencies[0];
|
||||||
if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) {
|
if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) {
|
||||||
dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane);
|
dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane);
|
||||||
|
ret = -EINVAL;
|
||||||
goto disable_clk;
|
goto disable_clk;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче