UBIFS: use an IS_ERR test rather than a NULL test
In case of error, the function kthread_create returns an ERR pointer, but never returns a NULL pointer. So a NULL test that comes before an IS_ERR test should be deleted. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @match_bad_null_test@ expression x, E; statement S1,S2; @@ x = kthread_create(...) ... when != x = E * if (x == NULL) S1 else S2 // </smpl> Signed-off-by: Julien Brunel <brunel@diku.dk> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
This commit is contained in:
Родитель
746103aca2
Коммит
a70948b564
|
@ -1032,8 +1032,6 @@ static int mount_ubifs(struct ubifs_info *c)
|
|||
|
||||
/* Create background thread */
|
||||
c->bgt = kthread_create(ubifs_bg_thread, c, c->bgt_name);
|
||||
if (!c->bgt)
|
||||
c->bgt = ERR_PTR(-EINVAL);
|
||||
if (IS_ERR(c->bgt)) {
|
||||
err = PTR_ERR(c->bgt);
|
||||
c->bgt = NULL;
|
||||
|
@ -1347,8 +1345,6 @@ static int ubifs_remount_rw(struct ubifs_info *c)
|
|||
|
||||
/* Create background thread */
|
||||
c->bgt = kthread_create(ubifs_bg_thread, c, c->bgt_name);
|
||||
if (!c->bgt)
|
||||
c->bgt = ERR_PTR(-EINVAL);
|
||||
if (IS_ERR(c->bgt)) {
|
||||
err = PTR_ERR(c->bgt);
|
||||
c->bgt = NULL;
|
||||
|
|
Загрузка…
Ссылка в новой задаче